r184438 - Fix CodeGenCXX/debug-info.cpp test on Windows

[David Blaikie]

On Jun 20, 2013 9:30 AM, "Reid Kleckner" <reid at kleckner.net> wrote:
>
> Author: rnk
> Date: Thu Jun 20 11:28:24 2013
> New Revision: 184438
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184438&view=rev
> Log:
> Fix CodeGenCXX/debug-info.cpp test on Windows
>
> On Windows, it looks like FlagIndirectVariable is being set in Flags for
> DIBuilder::createLocalVariable(), giving us an i32 of 8192 instead of 0,
> as on Linux.
>
> Fixes breakage from r184367.
>
> Modified:
>     cfe/trunk/test/CodeGenCXX/debug-info.cpp
>
> Modified: cfe/trunk/test/CodeGenCXX/debug-info.cpp
> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-info.cpp?rev=184438&r1=184437&r2=184438&view=diff
>
==============================================================================
> --- cfe/trunk/test/CodeGenCXX/debug-info.cpp (original)
> +++ cfe/trunk/test/CodeGenCXX/debug-info.cpp Thu Jun 20 11:28:24 2013
> @@ -92,7 +92,7 @@ incomplete (*x)[3];
>  }
>
>  // For some reason the argument for PR14763 ended up all the way down
here
> -// CHECK: = metadata !{i32 {{[0-9]*}}, metadata [[FUNC]], {{.*}},
metadata [[FOO]], i32 8192, i32 0} ; [ DW_TAG_arg_variable ] [f]
> +// CHECK: = metadata !{i32 {{[0-9]*}}, metadata [[FUNC]], {{.*}},
metadata [[FOO]], i32 {{[0-9]+}}, i32 0} ; [ DW_TAG_arg_variable ] [f]

Except I need that test that the flag is indirect (8193) to ensure we emit
the right location info for this parameter. So now the test is too
permissive.

Should we xfail this on windows &mention a PR for it instead?

>
>  namespace pr16214 {
>  struct a {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130620/7ae3da80/attachment.html>