[PATCH] Use ARM-style representation for C++ method pointers under PNaCl

Mark Seaborn mseaborn at chromium.org
Wed Jun 19 13:05:56 PDT 2013


On 19 June 2013 13:01, Mark Seaborn <mseaborn at chromium.org> wrote:

> Use ARM-style representation for C++ method pointers under PNaCl
>
> Before this change, Clang uses the x86 representation for C++ method
> pointers when generating code for PNaCl.  However, the resulting code
> will assume that function pointers are 0 mod 2.  This assumption is
> not safe for PNaCl, where function pointers could have any value
> (especially in future sandboxing models).
>
> So, switch to using the ARM representation for PNaCl code, which makes
> no assumptions about the alignment of function pointers.
>
> See: https://code.google.com/p/nativeclient/issues/detail?id=3450
>

Oops, I meant to send this to cfe-commits rather than llvm-commits.

Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130619/6eae693d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 1643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130619/6eae693d/attachment.obj>


More information about the cfe-commits mailing list