r183631 - [CodeGen] Move EHScopeStack to CGCleanup.h from CodeGenFunction.h

[John McCall]

On Jun 19, 2013, at 5:32 AM, Reid Kleckner <rnk at google.com> wrote:
> On Tue, Jun 18, 2013 at 8:07 PM, John McCall <rjmccall at apple.com> wrote:
> On Jun 9, 2013, at 9:45 AM, Reid Kleckner <reid at kleckner.net> wrote:
> > Author: rnk
> > Date: Sun Jun  9 11:45:02 2013
> > New Revision: 183631
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=183631&view=rev
> > Log:
> > [CodeGen] Move EHScopeStack to CGCleanup.h from CodeGenFunction.h
> >
> > No functionality change.  CGCleanup.cpp provides the implementation for
> > EHScopeStack, so it seems more consistent to place the class definition
> > in CGCleanup.h.
> 
> So, I specifically wasn't doing this because I didn't want to include
> CGCleanup.h in every file in IR-gen, basically because I didn't want
> random files depending on the cleanup-stack details.
> 
> Hm.  I needed this in order to reference EHScopeStack::stable_iterator from CallArgList in CGCall.h, which is included by CodeGenFunction.h.  I couldn't forward declare it, so this seemed cleaner.
> 
> lib/CodeGen/CGEHScopeStack.h then?

Just EHScopeStack.h, please.

John.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130619/6a73008f/attachment.html>