[PATCH] Fix bug in MS property handling

Reid Kleckner rnk at google.com
Wed Jun 19 09:39:08 PDT 2013


Sure, r184319.  Thanks for the patch!


On Tue, Jun 18, 2013 at 11:25 AM, Will Wilson <will at indefiant.com> wrote:

> Thanks for the reviews! Any chance someone with rights can commit it?
>
> Cheers,
> Will.
>
>
> On 18 June 2013 00:59, Richard Smith <richard at metafoo.co.uk> wrote:
>
>> On Mon, Jun 17, 2013 at 3:21 PM, Will Wilson <will at indefiant.com> wrote:
>> > *ping*
>> >
>> > Anyone with time to take a look at this? It's pretty minor, so with any
>> luck
>> > it can be committed forthwith.
>>
>> LGTM
>>
>> > On 14 June 2013 12:18, Will Wilson <will at indefiant.com> wrote:
>> >>
>> >> Hi All,
>> >>
>> >> The attached patch fixes a bug in the MS property handling when
>> properties
>> >> are passed as arguments when the getter returns a reference to the
>> declared
>> >> type. Notably this fixes an error (and asserts) when parsing the core
>> >> Windows header atlbase.h.
>> >>
>> >> The patch includes tests and is built against the latest clang trunk.
>> >>
>> >> Please review and commit if everything looks good.
>> >>
>> >> Cheers!
>> >> Will.
>> >>
>> >
>> >
>> >
>> > --
>> > Indefiant Ltd.
>> >
>> > Firsby Lodge, New Main Road, Scamblesby, Louth, Lincs LN11 9XH UK
>> > Tel: +44 20 8123 7663 England Registered No. 07936820 VAT No. 128556202
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> >
>>
>
>
>
> --
> *Indefiant Ltd.*
> *
> *
> Firsby Lodge, New Main Road, Scamblesby, Louth, Lincs LN11 9XH UK
> *Tel: +44 20 8123 7663 England Registered No. 07936820 VAT No. **128556202
> *
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130619/8bd9ccf0/attachment.html>


More information about the cfe-commits mailing list