r184205 - CodeGen: Have 'this'-returning constructors and destructors to take advantage of the new backend 'returned' attribute.

Stephen Lin stephenwlin at gmail.com
Tue Jun 18 13:35:33 PDT 2013


That makes sense, but I'm curious if or why this ever worked on
Windows, since the tests depend on Itanium name mangling. Are these
automatically excluded from the test suite when run on Windows?
Stephen

On Tue, Jun 18, 2013 at 12:53 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Tue, Jun 18, 2013 at 12:30 PM, Stephen Lin <stephenwlin at gmail.com> wrote:
>>
>> Hmm, this apparently breaks tests when run on ARM, because the tests
>> are using the host triple...why are there tests that don't set an
>> explicit triple?
>>
>> Does anyone know the standard procedure for resolving something like
>> this? I can make the tests triple-specific but I'm not sure why they
>> weren't in the first place. The optimization affects only ARM and MSVC
>> C++ ABI's so I cannot change the results for all targets.
>>
>
> Sometimes we let tests run without a specified ABI if they are mostly
> non-target-specific; this lets the buildbots exercise a few more code paths.
> Feel free to add triples where necessary, though.
>
> -Eli



More information about the cfe-commits mailing list