[patch] Cleanup linkage computation for static locals

Eli Friedman eli.friedman at gmail.com
Mon Jun 17 10:53:25 PDT 2013


This won't apply cleanly to trunk; I changed the code in CGDecl.cpp.

That said, the other parts look fine.

-Eli


On Mon, Jun 17, 2013 at 7:18 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> ping
>
> On 6 June 2013 17:42, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> >> Hmm.  I think you should use the linkage of the enclosing function
> >> instead of linkonce_odr;  in particular, if the enclosing function is an
> >> explicit template instantiation, the static local should have weak_odr
> >> linkage.
> >
> > Good catch. I have fixed it and include a testcase.
> >
> > Cheers,
> > Rafael
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130617/51f4bffd/attachment.html>


More information about the cfe-commits mailing list