[PATCH] [Driver] Refactor clang driver to use LLVM's Option library

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Jun 14 07:45:22 PDT 2013



================
Comment at: include/clang/Frontend/Utils.h:112
@@ -106,2 +111,3 @@
 
-}  // end namespace clang
+/// getLastArgValue - Return the value of the last argument as an integer,
+/// or a default. If Diags is non-null, emits an error if the argument
----------------
The name in the comment in wrong. The current style is to not repeat the function name in the comment.

================
Comment at: lib/Driver/ToolChains.h:19
@@ -18,3 +18,2 @@
 #include "llvm/Support/Compiler.h"
-
 #include <vector>
----------------
Please avoid this whitespace only change.


http://llvm-reviews.chandlerc.com/D975

BRANCH
  driver-refactor

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list