[PATCH] Bug 14984 - Implement __attribute__((ms_abi))

[Benno Rice]

On 12/06/2013, at 10:40 PM, Reid Kleckner <rnk at google.com> wrote:

> On Wed, Jun 12, 2013 at 7:13 AM, Charles Davis <cdavis5x at gmail.com> wrote:
> 
> On Jun 11, 2013, at 4:05 PM, Reid Kleckner wrote:

[snip]

>> What's lacking today is a way to get at the win64 convention in Clang or from LLVM when targetting a non-Windows platform.  LLVM might want to have a different internal name that's less vague that "ms_abi", though.
> You mean like in my patch here:
> 
> http://llvm-reviews.chandlerc.com/D729
> 
> ?
> 
> Yeah, that looks good to me.  :)
> 
> From the docs, it seems attr(ms_abi) just maps to x86_64_win64cc and x86_stdcallcc depending on the architecture:
> http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#index-g_t_0040code_007bsysv_005fabi_007d-attribute-2670
> gcc also appears to support a sysv_abi attribute, which lets you use the sysv CCs when targeting Windows.

For the record, I'm not fussed as to which patch goes in. It's the functionality I care about. =)

Cheers,
	Benno.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130613/03404426/attachment.html>