[PATCH] Bug 14984 - Implement __attribute__((ms_abi))

[Richard Smith]

On Tue, Jun 11, 2013 at 3:44 AM, Benno Rice <benno at freebsd.org> wrote:
> Hi all,
>
> I've attached a patch to the bug at:
>
> http://llvm.org/bugs/show_bug.cgi?id=14984
>
> that implements the necessary glue to support __attribute__((ms_abi)).
>
> If anyone has any questions, please let me know off-list.

It's not clear to me that representing this as a separate calling
convention in Clang is the right approach. We support at least four
different calling conventions when targeting the MS ABI (__cdecl,
__fastcall, __stdcall, __thiscall); perhaps this attribute should be
mapped to the appropriate member from that set? What should
__attribute__((ms_abi)) do when we're targeting the MS ABI already?
(Do you get a canonically-different type, or the same type, or is it
an error?)