[PATCH] Reduce number of symbols related to the dynamic wrappers.

Samuel Benzaquen sbenza at google.com
Tue Jun 11 09:22:40 PDT 2013



================
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:82
@@ +81,3 @@
+
+  typedef DynTypedMatcher *(*MarshallerType)(FuncType, StringRef,
+                                             const SourceRange &,
----------------
Manuel Klimek wrote:
> A comment would help me understand what we're now doing here...
Done.

================
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:190
@@ +189,3 @@
+  bool HasError = false;
+  for (size_t I = 0, E = Args.size(); I != E; ++I) {
+    if (!Args[I].Value.isTypedMatcher<DerivedType>()) {
----------------
Manuel Klimek wrote:
> I think common practice is to use "i" and "e" for counters, and I and E for iterators...
Done.


http://llvm-reviews.chandlerc.com/D948

BRANCH
  less_symbols

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list