[PATCH] CSA's StreamChecker - additional functionality and fix

Anna Zaks ganna at apple.com
Mon Jun 10 20:41:24 PDT 2013

On Jun 9, 2013, at 11:05 PM, Alexey Sidorin <a.sidorin at samsung.com> wrote:

> Anna,
> Sorry, I didn't know about further replacement of this checker.
> What should I do? Should I rewrite this code for SimpleStreamChecker or it should be done by somebody other?


Looks like Adam Schnitzer had started rewriting the checker. See "[Analyzer] [PATCH] Adding file name to SimpleStreamChecker". I'll review the patch this or next week.

Adam, sorry for not reviewing your patch sooner. Are you still interested in working on rewriting the Stream Checker?

> 08.06.2013 00:21, Anna Zaks пишет:
>> Alexey,
>> There are several subtle issues with the existing alpha StreamChecker. It's easier and cleaner to just add the supported APIs from the old checker to the new StreamChecker that would be based on the SimpleStreamChecker. Basically, we'd like to remove the old StreamChecker and write a new StreamChecker based on SimpleStreamChecker. Your improvements could be added on top of that.
>> What do you think?
>> Anna.
>> On Jun 7, 2013, at 5:05 AM, Alexey Sidorin <a.sidorin at samsung.com> wrote:
>>> Hi,
>>> I wrote a patch for Clang Static Analyzer's StreamChecker. This patch:
>>> 1. adds a check for descriptor access (read/write) after it being closed
>>> 2. adds support of directory operations (opendir/closedir and some other)
>>> 3. fixes issue in double close check: descriptor that was not tracked before was not marked as closed while calling a close function
>>> 4. adds fprintf and fscanf functions to track.
>>> Is it OK to commit or have I done something wrong?
>>> -- 
>>> Best regards,
>>> Alexey Sidorin,
>>> Programming Tools Part, CSG, SMRC, Samsung Electronics
>>> <StreamChecker.patch>_______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> -- 
> Best regards,
> Alexey Sidorin,
> Programming Tools Part, CSG, SMRC, Samsung Electronics

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130610/a031b644/attachment.html>

More information about the cfe-commits mailing list