r183084 - Properly consider the range of enum for range comparisons in C mode

David Majnemer david.majnemer at gmail.com
Fri Jun 7 11:35:07 PDT 2013


On Friday, June 7, 2013, John McCall wrote:

> On Jun 2, 2013, at 1:11 AM, David Majnemer <david.majnemer at gmail.com<javascript:;>>
> wrote:
> > Author: majnemer
> > Date: Sun Jun  2 03:11:22 2013
> > New Revision: 183084
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=183084&view=rev
> > Log:
> > Properly consider the range of enum for range comparisons in C mode
> >
> > In some cases, clang applies the C++ rules for computing the range of a
> > value when said value is an enum.
> >
> > Instead, apply C semantics when in C mode.
>
> Was this proposed or reviewed somewhere?  This is totally wrong.


It was proposed on this list in the form of a patch and LGTM'd. I then
waited for more comments and received none.


>
> John.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130607/da8de95f/attachment.html>


More information about the cfe-commits mailing list