[PATCH] cpp11-migrate: Refactor how global options are passed to Transforms

[Tareq A. Siraj]

================
Comment at: cpp11-migrate/Core/Transform.h:141
@@ -118,8 +140,3 @@
   /// text)
-  /// \param EnableTiming Enable the timing of the duration between calls to
-  /// handleBeginSource() and handleEndSource(). When a Transform object is
-  /// registered for FrontendAction source file callbacks, this behaviour can
-  /// be used to time the application of a MatchFinder by subclasses. Durations
-  /// are automatically stored in a TimingVec.
-  Transform(llvm::StringRef Name, bool EnableTiming)
-      : Name(Name), EnableTiming(EnableTiming) {
+  Transform(llvm::StringRef Name, const TransformOptions &Options)
+      : Name(Name), GlobalOptions(Options) {
----------------
Please add doxygen docs for the Options param.

================
Comment at: cpp11-migrate/tool/Cpp11Migrate.cpp:85
@@ +84,3 @@
+static cl::opt<bool, /*ExternalStorage=*/true> EnableHeaderModifications(
+    "h",
+    cl::Hidden, // Experimental feature for now.
----------------
-h kind of makes the impression that its a short form of --help. Can we pick a better name here? e.g. -modify-headers or -include-headers?

================
Comment at: unittests/cpp11-migrate/PerfSupportTest.cpp:7
@@ -6,2 +6,3 @@
 
+
 class TransformA : public Transform {
----------------
Remove empty line.


http://llvm-reviews.chandlerc.com/D931