[PATCH] [ms-cxxabi] Move CodeGenVTables::needsVTTParameter to ItaniumCXXABI.

[Reid Kleckner]

LGTM, this seems like a straightforward code shuffle that doesn't need
further review.


On Mon, May 20, 2013 at 9:19 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

>
>   LGTM
>
>
> ================
> Comment at: lib/CodeGen/CGCXXABI.h:326
> @@ +325,3 @@
> +  /// Return whether the given global decl needs a VTT parameter.
> +  virtual bool NeedsVTTParameter(GlobalDecl GD);
> +
> ----------------
> I think we should eventually move this method completely into
> ItaniumCXXABI (as it doesn't make sense for some other ABIs) but I agree
> doing this right now would require too much of a code change.
> Feel free to add a FIXME for that in the comment above.
>
>
> http://llvm-reviews.chandlerc.com/D821
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130605/35078819/attachment.html>