[PATCH] [ms-cxxabi] Add CGCXXABI::NeedsBodylessEmission function.

Reid Kleckner rnk at google.com
Wed Jun 5 09:45:24 PDT 2013


  Also, pinging John since this is more interface-y.


================
Comment at: lib/CodeGen/CGCXXABI.h:322
@@ +321,3 @@
+  /// Returns true if the ABI requires that we emit a definition for this
+  /// function, given that we don't have a definition for it in the TU.
+  virtual bool NeedsBodylessEmission(GlobalDecl GD);
----------------
Timur Iskhodzhanov wrote:
> Would be nice to give an example of when it's needed, otherwise it's a bit cryptic.
"bodyless emission" is confusing to me, but I can't invent a better name.  So long as the doc comment explains that this only makes sense when we can do something like delegate to a different variant of the function expected to be emitted in some other TU, then this works for me.


http://llvm-reviews.chandlerc.com/D820



More information about the cfe-commits mailing list