[clang-tools-extra] r183154 - cpp11-migrate: turn off PID-based perf data filenames

Kim Gräsman kim.grasman at gmail.com
Wed Jun 5 03:44:50 PDT 2013


On Mon, Jun 3, 2013 at 11:14 PM, Edwin Vane <edwin.vane at intel.com> wrote:
> Author: revane
> Date: Mon Jun  3 16:14:24 2013
> New Revision: 183154
>
> URL: http://llvm.org/viewvc/llvm-project?rev=183154&view=rev
> Log:
> cpp11-migrate: turn off PID-based perf data filenames
>
> Getting PIDs on Windows is broken. Proper fix is simple but requires testing so
> just disabling PID-based file names for now.

I can cook up a patch to change the Windows implementation to use PIDs
instead of process handles. I can't find any uses of
llvm::sys::process::get_id() in LLVM + Clang (I don't have tools or
other related projects checked out), so it should be relatively safe.

If I post it to Phabricator, can someone take a look and commit it to
the LLVM tree for me?

Thanks,
- Kim



More information about the cfe-commits mailing list