[clang-tools-extra] r183154 - cpp11-migrate: turn off PID-based perf data filenames

Edwin Vane edwin.vane at intel.com
Mon Jun 3 14:14:24 PDT 2013


Author: revane
Date: Mon Jun  3 16:14:24 2013
New Revision: 183154

URL: http://llvm.org/viewvc/llvm-project?rev=183154&view=rev
Log:
cpp11-migrate: turn off PID-based perf data filenames

Getting PIDs on Windows is broken. Proper fix is simple but requires testing so
just disabling PID-based file names for now.


Modified:
    clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp

Modified: clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp?rev=183154&r1=183153&r2=183154&view=diff
==============================================================================
--- clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp (original)
+++ clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp Mon Jun  3 16:14:24 2013
@@ -103,8 +103,12 @@ void reportExecutionTimes(
   P.createDirectoryOnDisk(true);
 
   // Get PID and current time.
-  llvm::sys::self_process *SP = llvm::sys::process::get_self();
-  unsigned Pid = SP->get_id();
+  // FIXME: id_type on Windows is NOT a process id despite the function name.
+  // Need to call GetProcessId() providing it what get_id() returns. For now
+  // disabling PID-based file names until this is fixed properly.
+  //llvm::sys::self_process *SP = llvm::sys::process::get_self();
+  //id_type Pid = SP->get_id();
+  unsigned Pid = 0;
   llvm::TimeRecord T = llvm::TimeRecord::getCurrentTime();
 
   std::string FileName;





More information about the cfe-commits mailing list