[patch] Fix PR16060

Richard Smith richard at metafoo.co.uk
Thu May 30 14:16:07 PDT 2013


Looks great, thanks.

On Thu, May 30, 2013 at 2:08 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> Hi Richard,
>
> Attached is a new version with the suggestions you had on irc.
>
> On 29 May 2013 22:19, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> > The testcase in PR16060 points out that while template arguments can
> > show that a type is not externally visible, the standards still says
> > they have external linkage.
> >
> > In terms of our implementation, it means that we should merge just the
> > isExternallyVisible bit, not the formal linkage.
> >
> > This patch does just that. Suggestion for a less confusing name than
> > LinkageVisibility are welcome!
> >
> > Cheers,
> > Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130530/a63b9267/attachment.html>


More information about the cfe-commits mailing list