[PATCH] Initial clang-tidy architecture

Daniel Jasper djasper at google.com
Wed May 29 12:12:11 PDT 2013



================
Comment at: clang-tidy/llvm/LLVMModule.cpp:88
@@ +87,3 @@
+    StringRef SourceFile = Sources.getFilename(HashLoc);
+    if (!SourceFile.endswith(".cc"))
+      return;
----------------
Sean Silva wrote:
> Daniel Jasper wrote:
> > Sean Silva wrote:
> > > Shouldn't this be checking LangOptions instead of the extension? e.g. this wouldn't work for LLVM's `.cpp` naming.
> > This is a dummy implementation. Any real order-check will be totally different.
> Please indicate this clearly somewhere!
Well, I intend to clean this up some more before submitting .. I thought this was clear enough for a first architectural review ..


http://llvm-reviews.chandlerc.com/D884



More information about the cfe-commits mailing list