[PATCH] [ms-cxxabi] There are no key functions in the Microsoft C++ ABI

Peter Collingbourne peter at pcc.me.uk
Wed May 29 09:23:29 PDT 2013



================
Comment at: test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp:119
@@ -112,2 +118,2 @@
 };
 void G::j() {}
----------------
Reid Kleckner wrote:
> Peter Collingbourne wrote:
> > Please also add a test which shows that defining what would be the key function in the Itanium ABI does not cause a vtable to be emitted.
> That's covered by C::f(), right?  I have a CHECK-NOT for that.
C::~C() is the key function, I believe.  Otherwise, the old test would be checking for a vtable.


http://llvm-reviews.chandlerc.com/D838

COMMIT
  http://llvm-reviews.chandlerc.com/rL182865



More information about the cfe-commits mailing list