[PATCH] Expand parsing of braced init lists.

Daniel Jasper djasper at google.com
Thu May 23 02:12:10 PDT 2013


  Looks good (under the circumstances ;-) ).


================
Comment at: lib/Format/UnwrappedLineParser.h:221
@@ -205,1 +220,3 @@
 
+  // FIXME: This is a temporary measure until le have reworked the ownership
+  // of the format tokens. The goal is to have the actual tokens created and
----------------
s/le/we/

================
Comment at: lib/Format/UnwrappedLineParser.h:223
@@ +222,3 @@
+  // of the format tokens. The goal is to have the actual tokens created and
+  // owned outside of the UnwrappedLineParser, and handed into the
+  // UnwrappedLineParser.
----------------
how about just:

// owned outside of and handed into the UnwrappedLineParser.

================
Comment at: lib/Format/UnwrappedLineParser.cpp:548
@@ +547,3 @@
+bool UnwrappedLineParser::tryToParseBracedList() {
+  if (LBraces[Tokens->getPosition()] == BS_Unknown) {
+    calculateBraceTypes();
----------------
No {}

================
Comment at: lib/Format/UnwrappedLineParser.cpp:136
@@ -126,1 +135,3 @@
 
+class AllTokenSource : public FormatTokenSource {
+public:
----------------
I know that this might be going away, but for now, how about "IndexedTokenSource"?


http://llvm-reviews.chandlerc.com/D848

BRANCH
  brace-init-hack

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list