[PATCH] Private Headers for Modules

Manuel Klimek klimek at google.com
Mon May 20 22:09:40 PDT 2013



================
Comment at: lib/Lex/PPDirectives.cpp:573-582
@@ +572,12 @@
+        ModuleMap::ModuleHeaderRole Role = SuggestedModule->getRole();
+        // // Check for consistency between the module header role
+        // // as obtained from the lookup and as obtained from the module.
+        // // This check is expensive, so enable it when needed.
+        // SmallVectorImpl<const FileEntry *> &PvtHdrs
+        //     = RequestedModule->PrivateHeaders;
+        // SmallVectorImpl<const FileEntry *>::iterator Look
+	//     = std::find(PvtHdrs.begin(), PvtHdrs.end(), FE);
+        // bool IsPrivate = Look != PvtHdrs.end();
+        // assert((IsPrivate && Role == ModuleMap::PrivateHeader)
+        //        || (!IsPrivate && Role != ModuleMap::PrivateHeader));
+        if (Role == ModuleMap::PrivateHeader) {
----------------
This looks unintentionally left as a comment?


http://llvm-reviews.chandlerc.com/D834



More information about the cfe-commits mailing list