[PATCH] [ms-cxxabi] Fix the base/complete dtor logic.

Peter Collingbourne peter at pcc.me.uk
Mon May 20 07:17:57 PDT 2013



================
Comment at: test/CodeGenCXX/microsoft-abi-structors.cpp:238
@@ +237,3 @@
+  A();
+  virtual void f(); // TODO: remove this function once we disable the key
+                    // function logic for the MS ABI.
----------------
Reid Kleckner wrote:
> So, in the MS ABI, key methods basically don't exist, right?  All class data is all comdat, all the time, and only emitted if it's used in the TU.  At least that's what I see so far.
That's also my understanding.


http://llvm-reviews.chandlerc.com/D823



More information about the cfe-commits mailing list