r182205 - Clang-format: allow -style="{yaml/json}" on command line

Alexander Kornienko alexfh at google.com
Sun May 19 04:08:11 PDT 2013


I thought it should be rather clear. But if you think otherwise, I'll try
to explain:
This commit adds support for specifying style configuration in yaml/json
format directly as a value of -style command-line option, e.g.
-style="{BasedOnStyle: llvm, IndentWidth: 8}". In addition to that it
improves getPredefinedStyle method and code handling default style (when no
-style specified on command line, or when an invalid style specified, or
when BasedOnStyle parameter is not specified in the used .clang-format
file, or when BasedOnStyle contains invalid style name). "Improved" here
means that there's now only one place where default style name is
specified, and fewer places where it's used.

Is this detailed enough?


On Sun, May 19, 2013 at 6:58 AM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Sun, May 19, 2013 at 12:53 AM, Alexander Kornienko <alexfh at google.com>wrote:
>
>> Clang-format: allow -style="{yaml/json}" on command line
>>
>> Summary: + improved handling of default style and predefined styles.
>>
>
> This description doesn't make a whole lot of sense... Can you clarify what
> is in this commit? (And watch out for this in the future, or fix whatever
> tool if it is a tool that messes this up?)
>



-- 
Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
77 957
Google Germany GmbH | Dienerstr. 12 | 80331 München
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130519/07af0a51/attachment.html>


More information about the cfe-commits mailing list