[PATCH] Enhancements for the DynTypedNode/DynTypedMatcher system.

Manuel Klimek klimek at google.com
Sat May 18 00:58:48 PDT 2013


On Sat, May 18, 2013 at 1:55 AM, Sean Silva <silvas at purdue.edu> wrote:

>
>   > Enhancements for the DynTypedNode/DynTypedMatcher system.
>   > - Added DynNodeType as a standalone way to represent node types and
> their hierarchy.
>   > - Added conversion routines and checks in Matcher<T> that take a
> DynTypedMatcher.
>   > - Fixed MatchFinder::addMatcherDynamic() to validate the input matcher.
>   > - Added type information on the error messages for the marshallers.
>   > - Allows future work on Polymorphic/overloaded matchers. We should be
> able to disambiguate at runtime and choose the appropriate overload.
>
>
>   Could you please split these up into separate patches so that they are
> easier to review?
>

+1. In general, always pull adding new headers / functionality to one of
clang's core modules (like AST) into their own change.


> http://llvm-reviews.chandlerc.com/D815
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130518/a9444229/attachment.html>


More information about the cfe-commits mailing list