r181627 - Avoid patching storage class for block scope thread_local variables.

Enea Zaffanella zaffanella at cs.unipr.it
Thu May 16 04:45:42 PDT 2013


On 05/15/2013 10:25 PM, Richard Smith wrote:
> Please move the tests into test/CodeGenCXX, merge into existing test
> files, and ensure that -emit-llvm is on the RUN: line. Maybe
> cxx11-thread-local.cpp for the first test and anonymous-namespaces.cpp
> for the second one?
>
> Otherwise, LGTM, thanks!

Added the patch and one of the tests in r181998.

As for the other test, adding it at the end of cxx11-thread-local.cpp 
results in a CHECK line failing to find its target. Since I know very 
little about llvm bytecode, I left this addition to someone more 
knowledgeable ... if you prefer, I can add those lines in their own test 
file.

Enea.




More information about the cfe-commits mailing list