r181940 - Objective-C: More cases of -Wsign-conversion not

[Fariborz Jahanian]

Author: fjahanian
Date: Wed May 15 17:25:03 2013
New Revision: 181940

URL: http://llvm.org/viewvc/llvm-project?rev=181940&view=rev
Log:
Objective-C: More cases of -Wsign-conversion not
working on new Objective-C array subscripting
syntax. // rdar://13855682

Modified:
    cfe/trunk/lib/Sema/SemaChecking.cpp
    cfe/trunk/test/SemaObjC/sign-conversion.m

Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=181940&r1=181939&r2=181940&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaChecking.cpp (original)
+++ cfe/trunk/lib/Sema/SemaChecking.cpp Wed May 15 17:25:03 2013
@@ -5135,11 +5135,13 @@ void AnalyzeImplicitConversions(Sema &S,
   // Now continue drilling into this expression.
   
   if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) {
-    Expr *Result = POE->getResultExpr();
-    if (const OpaqueValueExpr *OVE = dyn_cast_or_null<OpaqueValueExpr>(Result))
-      return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC);
+    if (POE->getResultExpr())
+      E = POE->getResultExpr();
   }
   
+  if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E))
+    return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC);
+  
   // Skip past explicit casts.
   if (isa<ExplicitCastExpr>(E)) {
     E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();

Modified: cfe/trunk/test/SemaObjC/sign-conversion.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/sign-conversion.m?rev=181940&r1=181939&r2=181940&view=diff
==============================================================================
--- cfe/trunk/test/SemaObjC/sign-conversion.m (original)
+++ cfe/trunk/test/SemaObjC/sign-conversion.m Wed May 15 17:25:03 2013
@@ -1,21 +1,39 @@
 // RUN: %clang_cc1 -fsyntax-only -verify -Wsign-conversion %s
 // rdar://13855394
 
+typedef unsigned int NSUInteger;
+
 @interface NSObject
 - new;
+- (NSUInteger)hash;
 @end
 
 @interface X : NSObject
- at property unsigned int uint;
+ at property NSUInteger uint;
 @end
 
- at implementation X 
- at synthesize uint;
+ at interface NSArray : NSObject 
+
+- (NSUInteger)count;
+- (id)objectAtIndex:(NSUInteger)index;
+- (id)objectAtIndexedSubscript:(NSUInteger)index;
+
 @end
 
 void foo() {
     X *x = [X new];
     signed int sint = -1;
-    [x setUint:sint];  // expected-warning {{implicit conversion changes signedness: 'int' to 'unsigned int'}}
-    x.uint = sint; // expected-warning {{implicit conversion changes signedness: 'int' to 'unsigned int'}}
+    [x setUint:sint];  // expected-warning {{implicit conversion changes signedness: 'int' to 'NSUInteger'}}
+    x.uint = sint; // expected-warning {{implicit conversion changes signedness: 'int' to 'NSUInteger'}}
+}
+
+// rdar://13855682
+void Test1() {
+signed int si = -1;
+NSArray *array;
+
+(void)((NSObject*)array[si]).hash; // expected-warning {{implicit conversion changes signedness: 'int' to 'NSUInteger'}}
+
+(void)[((NSObject*)array[si]) hash]; // expected-warning {{implicit conversion changes signedness: 'int' to 'NSUInteger'}}
+(void)array[si]; // expected-warning {{implicit conversion changes signedness: 'int' to 'NSUInteger'}}
 }