[PATCH] Add support for polymorphic matchers.

Manuel Klimek klimek at google.com
Tue May 14 11:46:01 PDT 2013



================
Comment at: lib/ASTMatchers/Dynamic/DynMatchers.cpp:35
@@ +34,3 @@
+          ast_matchers::internal::BoundNodesTreeBuilder *Builder) const {
+    return M1->matches(DynNode, Finder, Builder) ||
+        M2->matches(DynNode, Finder, Builder);
----------------
How much harder would it be to not re-implement the matchers? I'd like to keep matcher implementations as cohesive as possible, as we want to be able to change the implementations when we introduce new features.


http://llvm-reviews.chandlerc.com/D794



More information about the cfe-commits mailing list