r181761 - Replace EXPECT_EQ with EXPECT_FALSE to avoid gcc warning

Daniel Jasper djasper at google.com
Tue May 14 00:57:17 PDT 2013


Thanks for the fix!


On Tue, May 14, 2013 at 9:53 AM, Patrik Hagglund <
patrik.h.hagglund at ericsson.com> wrote:

> Author: patha
> Date: Tue May 14 02:53:53 2013
> New Revision: 181761
>
> URL: http://llvm.org/viewvc/llvm-project?rev=181761&view=rev
> Log:
> Replace EXPECT_EQ with EXPECT_FALSE to avoid gcc warning
> [-Wconversion-null], introduced in r181326.
>
> Modified:
>     cfe/trunk/unittests/Format/FormatTest.cpp
>
> Modified: cfe/trunk/unittests/Format/FormatTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=181761&r1=181760&r2=181761&view=diff
>
> ==============================================================================
> --- cfe/trunk/unittests/Format/FormatTest.cpp (original)
> +++ cfe/trunk/unittests/Format/FormatTest.cpp Tue May 14 02:53:53 2013
> @@ -4122,9 +4122,9 @@ TEST_F(FormatTest, ParsesConfiguration)
>  #define CHECK_PARSE_BOOL(FIELD)
>      \
>    Style.FIELD = false;
>       \
>    EXPECT_EQ(0, parseConfiguration(#FIELD ": true", &Style).value());
>       \
> -  EXPECT_EQ(true, Style.FIELD);
>      \
> +  EXPECT_TRUE(Style.FIELD);
>  \
>    EXPECT_EQ(0, parseConfiguration(#FIELD ": false", &Style).value());
>      \
> -  EXPECT_EQ(false, Style.FIELD);
> +  EXPECT_FALSE(Style.FIELD);
>
>    CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft);
>    CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine);
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130514/6802eb91/attachment.html>


More information about the cfe-commits mailing list