[Patch] Better diagnostics for string initialization (and fix for C11)

Hans Wennborg hans at chromium.org
Mon May 13 09:49:32 PDT 2013


Hi all,

The attached patch fixes Clang's diagnostics concerning string
initialization. Where it would previously say:

  /tmp/a.c:3:9: error: array initializer must be an initializer list
  wchar_t s[] = "Hi";
          ^
  /tmp/a.c:4:6: error: array initializer must be an initializer list
or string literal
  char t[] = L"Hi";
       ^

It will now say

  /tmp/a.c:3:9: error: initializing wide char array with non-wide string literal
  wchar_t s[] = "Hi";
          ^
  /tmp/a.c:4:6: error: initializing char array with wide string literal
  char t[] = L"Hi";
       ^

As a bonus, it also fixes the fact that Clang would previously reject
this valid C11 code:

  char16_t s[] = u"hi";
  char32_t t[] = U"hi";1

because it would only recognize the built-in types for char16_t and
char32_t, which do not exist in C.

Please take a look.

Thanks,
Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: string-init-diags.patch
Type: application/octet-stream
Size: 15988 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130513/94bc3e28/attachment.obj>


More information about the cfe-commits mailing list