[patch] Cleanup handling of UniqueExternalLinkage.

Richard Smith richard at metafoo.co.uk
Fri May 10 18:50:05 PDT 2013


On Fri, May 10, 2013 at 6:41 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> > I don't like the name 'getRawLinkage()'. I have no idea what it means,
> and
> > the comment doesn't help.
>
> Would adding a comment about UniqueExternalLinkage be sufficient? If
> not, what about getImplementationLinkage?


getImplementationLinkage works for me. Presumably the intent is that this
would continue to be the linkage-used-for-code-emission once we fix the
various cases where getFormalLinkage does not return the
linkage-as-specified-in-the-standard, so just a comment about
UniqueExternalLinkage seems insufficient going forward.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130510/4c6713b4/attachment.html>


More information about the cfe-commits mailing list