[PATCH] Was: Re: r178663 - Don't compute a patched/semantic storage class.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri May 10 08:06:50 PDT 2013

> My 2 cents:
>  - getStorageClassSpec() is a method of DeclSpec, whose instances are
> transient objects built during parsing and die soon after being used to
> construct the AST nodes; these objects typically only contain syntactic
> stuff, so the "AsWritten" suffix seems redundant;
>  - getStorageClass() is a method of VarDecl/FunctionDecl nodes;
> AST nodes have a longer lifetime and usually mix both syntactic and semantic
> info; the method is used, for instance, in CodeGen and Analysis ... I guess
> these ones care more about semantics.
> Hence, adding the "AsWritten" suffix here seems a reasonable choice to warn
> some of the AST clients.
> Anyway, if any renaming is to be done, it should go in its own patch.
> Therefore, OK to commit the submitted patch?

I agree. Any renaming should go in another patch. I think the patch is
OK, but please wait far a confirmation from Richard or Douglas.

> Enea.


More information about the cfe-commits mailing list