[PATCH] Config file support for clang-format, part 2.

Alexander Kornienko alexfh at google.com
Fri May 10 04:57:24 PDT 2013



================
Comment at: lib/Format/Format.cpp:61
@@ +60,3 @@
+        if (Style == clang::format::getPredefinedStyle(StyleName)) {
+          IO.mapOptional("# BasedOnStyle", StyleName);
+          break;
----------------
Kim Gräsman wrote:
> IIRC, the YAML parser doesn't take "#" comments, only JavaScript-style "//", but I'm not 100% sure. Did you try roundtripping a dumped configuration?
There's a round-trip test, and it passes for me.


http://llvm-reviews.chandlerc.com/D758

BRANCH
  svn

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list