[PATCH]Fix another TemplateParameterDepth Bug

Faisal Vali faisalv at gmail.com
Fri May 10 03:51:08 PDT 2013

As per Chandler's suggestion to separate out the bug fix from the
refactoring - see comment below regarding this bug fix patch.

Thank you!

Faisal Vali

On Thu, May 9, 2013 at 11:36 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Fri, May 10, 2013 at 6:14 AM, Faisal Vali <faisalv at gmail.com> wrote:
>> As I was working on captures within Generic Lambdas, I thought it would
>> be nice to refactor the very long function : tryCaptureVariable. Please let
>> me know if you think this refactoring is useful and if you have any
>> suggestions for improving the refactoring.
>> Also, I fixed a bug in my initial TemplateParameterDepth patch - the
>> Depth counter was getting incremented when it shouldn't have (that is for a
>> non-class template) in delayed-template parsing mode.  I included a test
>> that previously asserted, and now compiles and behaves as it should.
> In general I think it would be very good to separate out these two patches
> (and similarly separable patches). I think getting the bug fix reviewed and
> in should be done independently of refactoring which doesn't change
> functionality.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130510/197582f2/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: template-parameter-depth-fix-dont-increment-if-not-classtemplate.patch
Type: application/octet-stream
Size: 1918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130510/197582f2/attachment.obj>

More information about the cfe-commits mailing list