[PATCH] Refactor tryCaptureVariable using ExtractMethod and fix another TemplateParameterDepth Bug

Faisal Vali faisalv at gmail.com
Thu May 9 21:14:23 PDT 2013

As I was working on captures within Generic Lambdas, I thought it would be
nice to refactor the very long function : tryCaptureVariable. Please let me
know if you think this refactoring is useful and if you have any
suggestions for improving the refactoring.

Also, I fixed a bug in my initial TemplateParameterDepth patch - the Depth
counter was getting incremented when it shouldn't have (that is for a
non-class template) in delayed-template parsing mode.  I included a test
that previously asserted, and now compiles and behaves as it should.

Thank you in advance for the feedback.

Faisal Vali
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130509/22ac00b7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: refactor-try-capture-var-and-fix-template-depth.patch
Type: application/octet-stream
Size: 32466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130509/22ac00b7/attachment.obj>

More information about the cfe-commits mailing list