[patch] Cleanup handling of UniqueExternalLinkage.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu May 9 13:54:50 PDT 2013


Hi Douglas,

Before trying to implement the C++11 rules for anonymous namespaces
(or fix pr15930) I would like to cleanup how we handle
UniqueExternalLinkage.

The attached patch is a nop. It just replaces most uses of getLinkage
with getSemaLinkage and getCodeGenLinkage. Some of these calls should
be audited to make sure they are calling the right function, but that
is probably better done in an independent patch, so this one is
mechanical:

hasExternalLinkage -> hasExternalCodeGenLinkage

isExternalLinkage(foo->getLinkage()) -> hasExternalSemaLinkage

getLinkage() == ExternalLinkage -> hasExternalCodeGenLinkage

getLinkage() == InternalLinkage  -> getSemaLinkage() == InternalLinkage

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 27383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130509/d380557b/attachment.obj>


More information about the cfe-commits mailing list