r181487 - put noisy "unknown command tag name" warning

Dmitri Gribenko gribozavr at gmail.com
Thu May 9 08:53:48 PDT 2013


On Thu, May 9, 2013 at 2:38 AM, Fariborz Jahanian <fjahanian at apple.com> wrote:
> Author: fjahanian
> Date: Wed May  8 18:38:56 2013
> New Revision: 181487
>
> URL: http://llvm.org/viewvc/llvm-project?rev=181487&view=rev
> Log:
> put noisy "unknown command tag name"  warning
> under -Wdocumentation-unknown-command and off by default.
> patch by Dmitri Gribenko.

Hi Fariborz, Doug,

This turned out to be not good enough:

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/2358/steps/build/logs/warnings%20%283808%29

We could fix all the warnings (doable, there are just a few headers
that are included all over the place), but writing '\n' in a comment
is not too uncommon, IMHO.  So I think we should not warn about
unknown single-character commands (or at least in cases where it is a
known escape sequence).

What do you think about this?

(My personal opinion is that selecting \ or @ for a command marker in
Doxygen was a bad choice, but that ship has sailed long ago...)

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list