[PATCH] First revision of the dynamic ASTMatcher library

Manuel Klimek klimek at google.com
Wed May 8 08:53:40 PDT 2013

  My first gut feeling reaction is that we'll want a different solution than to make DynTypedNode more complex, and thus less predictable.

  We had a reason for have the explicit overloads in the ASTMatchFinder instead of just working on the interface - the problem is that you can otherwise hand in lots of matchers that are impossible to get a match with...

  Things we could consider:
  1. take a DynTypedMatcher* and take ownership - together with clone(), this allows users to do everything they need, and doesn't lead to overload confusion.
  2. only have the DynTypedMatcher interface, and somehow break dynamically with an error message
  other ideas?




More information about the cfe-commits mailing list