[PATCH] [ms-cxxabi] Implement member pointer conversions
ripzonetriton at gmail.com
Wed May 8 08:04:50 PDT 2013
I've read through the patch and things seem to make sense to me, but I'm
afraid at this point you are the only one that fully understands all the
corner cases, so I can't give more detailed comments.
On Wed, May 8, 2013 at 3:56 PM, Reid Kleckner <rnk at google.com> wrote:
> Any thoughts on this? This was a bunch of fun to work out. =D
> The commit message I wrote is all wrong about the reinterpret_cast
> corner case. For reinterpret_cast, you have to do null conversion,
> but all other conversions are impl-defined, and the easiest conversion
> is a no-op.
> On Fri, May 3, 2013 at 6:59 PM, Reid Kleckner <rnk at google.com> wrote:
> > - Fix null handling for reinterpret casts.
> > Hi rjmccall,
> > http://llvm-reviews.chandlerc.com/D741
> > CHANGE SINCE LAST DIFF
> > http://llvm-reviews.chandlerc.com/D741?vs=1827&id=1828#toc
> > Files:
> > lib/CodeGen/MicrosoftCXXABI.cpp
> > test/CodeGenCXX/microsoft-abi-member-pointers.cpp
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits