r181368 - Don't crash in IRGen if a conditional with 'throw' in one of its branches is

John McCall rjmccall at apple.com
Tue May 7 16:07:00 PDT 2013


On May 7, 2013, at 2:53 PM, Richard Smith <richard-llvm at metafoo.co.uk> wrote:
> Author: rsmith
> Date: Tue May  7 16:53:22 2013
> New Revision: 181368
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=181368&view=rev
> Log:
> Don't crash in IRGen if a conditional with 'throw' in one of its branches is
> used as a branch condition.

Hmm.  Maybe we should have some sort of CK_BottomToAnything implicit
conversion node here instead of forcing all the clients to explicitly deal with
the vanishingly-uncommon operand-is-a-throw case all over the place.

Did you audit everything else that generates code for conditional operators
to ensure that they deal with it?

John.



More information about the cfe-commits mailing list