r181329 - Prevent crashes from hasCanonicalType matcher

Richard Smith richard at metafoo.co.uk
Tue May 7 10:17:47 PDT 2013


On Tue, May 7, 2013 at 10:04 AM, Vane, Edwin <edwin.vane at intel.com> wrote:

> Probably a good idea. Who has to do that?


Please add a test case, then ask the code owner to approve for the branch
(and CC the release manager).

The code owner for ASTMatchers should probably be Manuel but appears to
currently be Doug. The release manager is Bill Wendling.

> -----Original Message-----
> > From: Dmitri Gribenko [mailto:gribozavr at gmail.com]
> > Sent: Tuesday, May 07, 2013 11:57 AM
> > To: Vane, Edwin
> > Cc: cfe-commits cfe
> > Subject: Re: r181329 - Prevent crashes from hasCanonicalType matcher
> >
> > On Tue, May 7, 2013 at 6:53 PM, Edwin Vane <edwin.vane at intel.com> wrote:
> > > Author: revane
> > > Date: Tue May  7 10:53:23 2013
> > > New Revision: 181329
> > >
> > > URL: http://llvm.org/viewvc/llvm-project?rev=181329&view=rev
> > > Log:
> > > Prevent crashes from hasCanonicalType matcher
> > >
> > > Adding an QualType::isNull() check.
> >
> > Shall we commit this to Clang 3.3 branch, too?
> >
> > Dmitri
> >
> > --
> > main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> > (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130507/0f87eba2/attachment.html>


More information about the cfe-commits mailing list