[PATCH] Add a Mozilla coding style to clang-format
alexfh at google.com
Mon May 6 07:06:04 PDT 2013
No, it doesn't. The only thing that bothers me a bit is that we don't have
any tests for this style. There's plenty of tests for LLVM style in form of
unit tests, but we still need some kind of file-based integration tests for
different style guides.
Anyway, I'm going to commit your patch with getMozillaStyle being based
upon getLLVMStyle: http://llvm-reviews.chandlerc.com/D750. If you have any
comments, you can share them on Phabricator.
On Mon, May 6, 2013 at 3:14 PM, Ehsan Akhgari <ehsan.akhgari at gmail.com>wrote:
> Does that mean that we can't take this patch in the mean time?
> On Mon, May 6, 2013 at 9:07 AM, Alexander Kornienko <alexfh at google.com>wrote:
>> I'm starting to work on configuration files for clang-format, which are
>> going to be a more flexible solution for per-project coding styles.
>> On Sun, May 5, 2013 at 9:28 PM, Ehsan Akhgari <ehsan.akhgari at gmail.com>wrote:
>>> Can someone please review and commit this patch? Thanks!
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>> Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151
>> 221 77 957
>> Google Germany GmbH | Dienerstr. 12 | 80331 München
Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
Google Germany GmbH | Dienerstr. 12 | 80331 München
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits