[PATCH] [ms-cxxabi] Emit non-virtual member function pointers

John McCall rjmccall at apple.com
Mon May 6 01:07:46 PDT 2013


On Apr 30, 2013, at 4:44 PM, Reid Kleckner <rnk at google.com> wrote:
>    - Don't regress users that have unused memptrs in globals.
>    - Fix Joao's comments and a bug.

   if (hasVBPtrOffsetField(Inheritance)) {
     int64_t VBPtrOffset =
       getContext().getASTRecordLayout(RD).getVBPtrOffset().getQuantity();
+    if (VBPtrOffset == -1)
+      VBPtrOffset = 0;

This really needs a comment.

Otherwise seems fine.

John.



More information about the cfe-commits mailing list