[PATCH] CodeGen for CapturedStmt

John McCall rjmccall at apple.com
Mon May 6 00:57:31 PDT 2013


On Apr 30, 2013, at 11:31 AM, Ben Langmuir <ben.langmuir at intel.com> wrote:
>  Updates per review
> 
>  Move some code into GenerateCapturedStmtFunction, and remove 'ThisValue'
>  from CGCapturedStmtInfo, which was confusing, since we already have
>  'this' in C++.
> 
>  Added tests for captured statements in a block (and vice-versa), as well
>  as a captured statement in a captured statement.  Disallowed capturing
>  __block variables in a captured statement, since we don't handle that in
>  codegen.

Yes, this looks generally fine to me.  You'll need to adjust very
slightly for my patch to the lambda handling.

John.




More information about the cfe-commits mailing list