[PATCH] First revision of the dynamic ASTMatcher library

Samuel Benzaquen sbenza at google.com
Fri May 3 14:36:00 PDT 2013



================
Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:56
@@ +55,3 @@
+  /// specific matcher nodes for more efficient lookup.
+  class TokenProcessor {
+  public:
----------------
Dmitri Gribenko wrote:
> This is the 'semantic analysis' (Sema) class, if we stick to Clang's terms.  Then the function inside it should be called like 'actOnMatcherExpression()'
Done.

================
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:11-13
@@ +10,5 @@
+/// \file
+/// \brief Template functions and classes to wrap matcher construct functions.
+///
+/// A collection of template function and classes that provide a generic
+/// marshalling layer on top of matcher construct functions.
----------------
Dmitri Gribenko wrote:
> s/Template functions/Function templates/
Done.


http://llvm-reviews.chandlerc.com/D714

BRANCH
  svn

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list