[PATCH] First revision of the dynamic ASTMatcher library

Samuel Benzaquen sbenza at google.com
Fri May 3 13:50:54 PDT 2013


  Thanks for the review. It has been a long time since I worked on a lexer/parser.
  At the beginning of this change I saw the parser itself as a fast way to test the registry code and didn't really invest much time on it. I think that by now it is the component I have spent more time on...


================
Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:254
@@ +253,3 @@
+/// parse function.
+bool Parser::parseNextToken(VariantValue *Value) {
+  const TokenInfo Token = Tokenizer->consumeNextToken();
----------------
Dmitri Gribenko wrote:
> Now the name of this function is completely bogus.
> 
> Please consider restructuring the parser so that the names of the functions reflect the productions in the grammar.
> 
> For example, this function should be probably called parseExpression().
You are totally right. Fixed.



http://llvm-reviews.chandlerc.com/D714

BRANCH
  svn

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list