[PATCH] [ms-cxxabi] Emit non-virtual member function pointers

Charles Davis cdavis5x at gmail.com
Tue Apr 30 21:31:53 PDT 2013


  Other than one small nit, LGTM. But (as you well know) @rjmccall has the final say here :).


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:142
@@ -141,1 +141,3 @@
 
+  /// EmitFullMemberPointer - Emits a full member pointer with the fields common
+  /// to data and function member pointers.
----------------
I recommend using `\brief` instead of repeating the method's name in the doc-comment like that.


http://llvm-reviews.chandlerc.com/D699



More information about the cfe-commits mailing list