r180629 - document parsing. When a sub-class (c++ Objective-C) missing

jahanian fjahanian at apple.com
Fri Apr 26 16:36:21 PDT 2013

On Apr 26, 2013, at 3:31 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Sat, Apr 27, 2013 at 1:24 AM, jahanian <fjahanian at apple.com> wrote:
>> Why does this test use -ast-dump?  Usually c-index-test is used to
>> test if comment is attached to something.  There are fewer CHECK lines
>> that way.
>> OK. I will add a c-index test (without removing the existing one which took
>> quite time
>> to get it right :).
> That's exactly why c-index-test tests are preferred: they are more
> maintainable.  So if you convert this file to c-index-test, just
> remove the original test.
> If you decide that you really need to go this way (I don't think this
> is a good approach, but anyway), please limit this to public
This meets our user needs. But, limiting it to public inheritance
makes sense. In r180646.
- Fariborz

> inheritance, which models is-a relationship.  It is semantically not
> appropriate to check private and protected bases for documentation.
> But private inheritance is not used much in C++, so this exclusion
> will not help much to reduce confusion.
> Dmitri
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130426/b7e3680f/attachment.html>

More information about the cfe-commits mailing list