Minor polishing of VTableBuilder

Timur Iskhodzhanov timurrrr at google.com
Fri Apr 26 10:13:59 PDT 2013

Hi Peter, Anders,

I was reading the source of Clang VTableBuilder sources to get
familiar with the code before writing a vftable generator for
Microsoft ABI.

I've decided to improve a couple of comments.
After improving one of the comments, fixing one of the FIXMEs in the
code became obvious, so I went ahead and just did it.
Please see the attached patch!

I also have a couple of questions, see the TODOs in the patch.
The most important is VTableBuilder::ComputeThisAdjustmentBaseOffset
where it's a bit unclear what's going on. It would be nice if we could
come up with a code which is easier to understand or at least a good
comment there.

Timur Iskhodzhanov,
Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vtables_comments.patch
Type: application/octet-stream
Size: 3839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130426/0bb2a662/attachment.obj>

More information about the cfe-commits mailing list