[PATCH] New SystemZ backend: clang changes

Richard Sandiford rsandifo at linux.vnet.ibm.com
Fri Apr 26 06:28:18 PDT 2013

Eric Christopher <echristo at gmail.com> writes:
>   Might be nice to see some tests for the inline assembly (front and
> backend if there weren't any there). The Target stuff LGTM
> otherwise. Someone else will need to get the rest of the changes.

Thanks.  How does this look?  The llvm side already has tests to
make sure that these kinds of asms are handled correctly (although I've
just added a couple more).

> ================
> Comment at: include/clang/AST/ASTContext.h:1583
> @@ +1582,3 @@
> +  /// global variable with type \p T.
> +  unsigned getGlobalAlign(QualType T) const;
> +
> ----------------
> Sadly I think most of the rest of llvm is using bits for alignment
> sizes, so you'll probably want to use bits here?

OK, I used a getGlobalAlign()/getGlobalAlignInChars() pair instead.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-systemz.diff
Type: text/x-patch
Size: 43679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130426/0d3bc641/attachment.bin>

More information about the cfe-commits mailing list